Skip to content

Normalize UNorm/SNorm vertex channels in MeshHandler - #401

Open
1915rising wants to merge 1 commit into
K0lb3:masterfrom
1915rising:fix/387-normalize-vertex-channels
Open

1915rising wants to merge 1 commit into
K0lb3:masterfrom
1915rising:fix/387-normalize-vertex-channels

Conversation

@1915rising

Copy link
Copy Markdown

Fixes #387.

MeshHandler.read_vertex_data returned normalized vertex channels as raw integers: a UNorm8 colour came back (255, 128, 0, 255) instead of (1.0, 0.502, 0.0, 1.0), and UNorm16 UVs exported to OBJ as vt 65535 32768. The compressed-mesh and copy_from_mesh paths already normalize, so the result depended on how the mesh was stored.

This normalizes channel data at unpack time (UNorm by format max, SNorm by signed max clamped to -1.0), across the legacy, 2017 and 2019+ format layouts and both the Python and UnityPyBoost unpack paths, matching the existing in-repo behaviour.

Tests: new parametrized regression tests in tests/test_mesh_helper.py pass (2 passed). The 3 remaining failures in that file are pre-existing and identical before/after: they need Git LFS sample files that are not fetched in my environment. Broader suite after the change: 39 passed, 4 failed, all four being the same LFS sample-data failures.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MeshHandler returns raw integers for UNorm and SNorm vertex channels

1 participant